fix: ensure correct inquiry routing to manager queue when manual routing is enabled by ricardogarim · Pull Request #35328 · RocketChat/Rocket.Chat

ricardogarim · 2025-02-25T03:44:11Z

Proposed changes (including videos or screenshots)

As per CORE-992, this PR ensures inquiries are correctly routed to the manager's queue when a contact manager is attached and manual routing is enabled.

Issue(s)

CORE-992

Steps to test or reproduce

Set omnichannel routing to manual.
Create two agents.
Create a contact with a known name and email, and assign it to one of the agents.
Create a livechat inquiry using the contact’s details.
Verify that the inquiry is only assigned to the contact’s designated manager.

Test cases:

Route to the correct online contact manager when routing is set to Manual Selection.
Route to the correct contact manager when routing is set to Manual Selection, contact manager is offline, and Livechat_accept_chats_with_no_agents is true.
Route to general queue when the contact manager is offline, and Livechat_accept_chats_with_no_agents is false.

Further comments

…ttached and routing is manual

dionisio-bot · 2025-02-25T03:44:15Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-02-25T03:44:15Z

🦋 Changeset detected

Latest commit: 6ffd482

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/ddp-client	Patch
@rocket.chat/meteor	Patch
@rocket.chat/livechat	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2025-02-25T03:50:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (041198c) to head (6ffd482).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35328      +/-   ##
===========================================
- Coverage    59.67%   59.64%   -0.04%     
===========================================
  Files         2826     2827       +1     
  Lines        68357    68522     +165     
  Branches     15142    15195      +53     
===========================================
+ Hits         40793    40867      +74     
- Misses       24951    24999      +48     
- Partials      2613     2656      +43

Flag	Coverage Δ
unit	`75.86% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

apps/meteor/server/modules/listeners/listeners.module.ts

apps/meteor/app/livechat/client/lib/stream/queueManager.ts

aleksandernsilva · 2025-02-26T19:25:06Z

@ricardogarim Don't forget to add a changeset ℹ️

github-actions · 2025-03-10T01:12:50Z

PR Preview Action v1.6.0
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35328/
Built to branch `gh-pages` at 2025-03-19 21:53 UTC. Preview will be ready when the GitHub Pages deployment is complete.

apps/meteor/app/livechat/server/lib/QueueManager.ts

fix: correctly route inquiry to its manager when contact manager is a…

36fc5c0

…ttached and routing is manual

ricardogarim added 3 commits February 25, 2025 08:33

typecheck

4fcbcad

aa

29e9acf

adds e2e test

2370039

ricardogarim force-pushed the fix/livechat-manual-routing-queue branch from a368859 to 2370039 Compare February 26, 2025 14:02

ricardogarim marked this pull request as ready for review February 26, 2025 15:33

ricardogarim requested review from a team as code owners February 26, 2025 15:33

ricardogarim added this to the 7.5.0 milestone Feb 26, 2025

aleksandernsilva requested changes Feb 26, 2025

View reviewed changes

apps/meteor/server/modules/listeners/listeners.module.ts Outdated Show resolved Hide resolved

apps/meteor/app/livechat/client/lib/stream/queueManager.ts Outdated Show resolved Hide resolved

apps/meteor/app/livechat/client/lib/stream/queueManager.ts Outdated Show resolved Hide resolved

ricardogarim added 4 commits March 9, 2025 21:42

extracts repeated event handling logic in queueManager

2cd0cd8

changes isOnlyQueueMetadataUpdate type from any to unknown

4a047ff

removes redundant listener calls

a80216e

adds changeset

5f9d055

MarcosSpessatto suggested changes Mar 10, 2025

View reviewed changes

apps/meteor/app/livechat/server/lib/QueueManager.ts Outdated Show resolved Hide resolved

ishaan-arora-1 added a commit to ishaan-arora-1/Rocket.Chat that referenced this pull request Mar 11, 2025

Fix: (Rocket.Chat RocketChat#35328) image editor added

5649182

ricardogarim added 2 commits March 19, 2025 09:26

makes manual routing work along with accept with no agents setting

18897d9

removes visitor update

e88d0ca

ricardogarim requested review from MarcosSpessatto, aleksandernsilva and sampaiodiego March 19, 2025 13:03

MarcosSpessatto approved these changes Mar 19, 2025

View reviewed changes

ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025

ricardogarim modified the milestone: 7.5.0 Mar 19, 2025

dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2025

Merge branch 'develop' into fix/livechat-manual-routing-queue

501a5bc

dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025

ricardogarim removed the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025

aleksandernsilva approved these changes Mar 19, 2025

View reviewed changes

ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Mar 19, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2025

ricardogarim added 2 commits March 19, 2025 17:12

Merge branch 'develop' into fix/livechat-manual-routing-queue

3f646f1

Merge branch 'develop' into fix/livechat-manual-routing-queue

6ffd482

sampaiodiego approved these changes Mar 19, 2025

View reviewed changes

kodiakhq bot merged commit a0c5f39 into develop Mar 19, 2025
48 checks passed

kodiakhq bot deleted the fix/livechat-manual-routing-queue branch March 19, 2025 22:51

rocketchat-github-ci mentioned this pull request Mar 20, 2025

Release 7.5.0 #35565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure correct inquiry routing to manager queue when manual routing is enabled#35328

fix: ensure correct inquiry routing to manager queue when manual routing is enabled#35328
kodiakhq[bot] merged 13 commits intodevelopfrom
fix/livechat-manual-routing-queue

ricardogarim commented Feb 25, 2025 •

edited

Loading

Uh oh!

dionisio-bot bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aleksandernsilva commented Feb 26, 2025

Uh oh!

github-actions bot commented Mar 10, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-03-19 21:53 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ricardogarim commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aleksandernsilva commented Feb 26, 2025

Uh oh!

github-actions bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2025-03-19 21:53 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ricardogarim commented Feb 25, 2025 •

edited

Loading

dionisio-bot bot commented Feb 25, 2025 •

edited

Loading

changeset-bot bot commented Feb 25, 2025 •

edited

Loading

codecov bot commented Feb 25, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

Built to branch `gh-pages` at 2025-03-19 21:53 UTC.
Preview will be ready when the GitHub Pages deployment is complete.